-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release note format #82
Merged
LitoMore
merged 7 commits into
simple-icons:master
from
LitoMore:update-release-note-format
Feb 10, 2024
Merged
Update release note format #82
LitoMore
merged 7 commits into
simple-icons:master
from
LitoMore:update-release-note-format
Feb 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrusted
reviewed
Feb 7, 2024
mondeja
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me though I like the @adamrusted's suggestion.
adamrusted
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Varying the maintainer names used, to properly demonstrate functionality works.
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the release note format to similar to
npm/cli
release note.The benefit is the
Contributors
section in the release note.I also removed the
core.debug(file)
. It's too long and super hard to read. We can simply use the GitHub REST API to check specific PR response. Or use ournpm run preview
script for debugging.